mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 06:38:13 +00:00
28e9a022df
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
15 lines
348 B
JavaScript
15 lines
348 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var net = require('net');
|
|
var assert = require('assert');
|
|
|
|
var c = net.createConnection(common.PORT, '...');
|
|
|
|
c.on('connect', common.fail);
|
|
|
|
c.on('error', common.mustCall(function(e) {
|
|
assert.equal(e.code, 'ENOTFOUND');
|
|
assert.equal(e.port, common.PORT);
|
|
assert.equal(e.hostname, '...');
|
|
}));
|