mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 03:45:25 +00:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
87 lines
2.1 KiB
JavaScript
87 lines
2.1 KiB
JavaScript
'use strict';
|
|
// Verify that the HTTP server implementation handles multiple instances
|
|
// of the same header as per RFC2616: joining the handful of fields by ', '
|
|
// that support it, and dropping duplicates for other fields.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
|
|
var multipleAllowed = [
|
|
'Accept',
|
|
'Accept-Charset',
|
|
'Accept-Encoding',
|
|
'Accept-Language',
|
|
'Connection',
|
|
'Cookie',
|
|
'DAV', // GH-2750
|
|
'Pragma', // GH-715
|
|
'Link', // GH-1187
|
|
'WWW-Authenticate', // GH-1083
|
|
'Proxy-Authenticate', // GH-4052
|
|
'Sec-Websocket-Extensions', // GH-2764
|
|
'Sec-Websocket-Protocol', // GH-2764
|
|
'Via', // GH-6660
|
|
|
|
// not a special case, just making sure it's parsed correctly
|
|
'X-Forwarded-For',
|
|
|
|
// make sure that unspecified headers is treated as multiple
|
|
'Some-Random-Header',
|
|
'X-Some-Random-Header',
|
|
];
|
|
|
|
var multipleForbidden = [
|
|
'Content-Type',
|
|
'User-Agent',
|
|
'Referer',
|
|
'Host',
|
|
'Authorization',
|
|
'Proxy-Authorization',
|
|
'If-Modified-Since',
|
|
'If-Unmodified-Since',
|
|
'From',
|
|
'Location',
|
|
'Max-Forwards',
|
|
|
|
// special case, tested differently
|
|
//'Content-Length',
|
|
];
|
|
|
|
var srv = http.createServer(function(req, res) {
|
|
multipleForbidden.forEach(function(header) {
|
|
assert.equal(req.headers[header.toLowerCase()],
|
|
'foo', 'header parsed incorrectly: ' + header);
|
|
});
|
|
multipleAllowed.forEach(function(header) {
|
|
assert.equal(req.headers[header.toLowerCase()],
|
|
'foo, bar', 'header parsed incorrectly: ' + header);
|
|
});
|
|
|
|
res.writeHead(200, {'Content-Type': 'text/plain'});
|
|
res.end('EOF');
|
|
|
|
srv.close();
|
|
});
|
|
|
|
function makeHeader(value) {
|
|
return function(header) {
|
|
return [header, value];
|
|
};
|
|
}
|
|
|
|
var headers = []
|
|
.concat(multipleAllowed.map(makeHeader('foo')))
|
|
.concat(multipleForbidden.map(makeHeader('foo')))
|
|
.concat(multipleAllowed.map(makeHeader('bar')))
|
|
.concat(multipleForbidden.map(makeHeader('bar')));
|
|
|
|
srv.listen(common.PORT, function() {
|
|
http.get({
|
|
host: 'localhost',
|
|
port: common.PORT,
|
|
path: '/',
|
|
headers: headers,
|
|
});
|
|
});
|