mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 11:29:26 +00:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
41 lines
1022 B
JavaScript
41 lines
1022 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var http = require('http');
|
|
|
|
var server = http.createServer(function(request, response) {
|
|
// removed headers should stay removed, even if node automatically adds them
|
|
// to the output:
|
|
response.removeHeader('connection');
|
|
response.removeHeader('transfer-encoding');
|
|
response.removeHeader('content-length');
|
|
|
|
// make sure that removing and then setting still works:
|
|
response.removeHeader('date');
|
|
response.setHeader('date', 'coffee o clock');
|
|
|
|
response.end('beep boop\n');
|
|
|
|
this.close();
|
|
});
|
|
|
|
var response = '';
|
|
|
|
process.on('exit', function() {
|
|
assert.equal('beep boop\n', response);
|
|
console.log('ok');
|
|
});
|
|
|
|
server.listen(common.PORT, function() {
|
|
http.get({ port: common.PORT }, function(res) {
|
|
assert.equal(200, res.statusCode);
|
|
assert.deepStrictEqual(res.headers, { date: 'coffee o clock' });
|
|
|
|
res.setEncoding('ascii');
|
|
res.on('data', function(chunk) {
|
|
response += chunk;
|
|
});
|
|
});
|
|
});
|