mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 06:38:13 +00:00
437930c0cc
If the URL passed to `http{s}.request` or `http{s}.get` is not properly
parsable by `url.parse`, we fall back to use `localhost` and port 80.
This creates confusing error messages like in this question
http://stackoverflow.com/q/32675907/1903116.
This patch throws an error message, if `url.parse` fails to parse the
URL properly.
Previous Discussion: https://github.com/nodejs/node/pull/2966
PR-URL: https://github.com/nodejs/node/pull/2967
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
20 lines
535 B
JavaScript
20 lines
535 B
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const https = require('https');
|
|
const error = 'Unable to determine the domain name';
|
|
|
|
function test(host) {
|
|
['get', 'request'].forEach((method) => {
|
|
[http, https].forEach((module) => {
|
|
assert.throws(() => module[method](host, () => {
|
|
throw new Error(`${module}.${method} should not connect to ${host}`);
|
|
}), error);
|
|
});
|
|
});
|
|
}
|
|
|
|
['www.nodejs.org', 'localhost', '127.0.0.1', 'http://:80/'].forEach(test);
|