mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 04:59:52 +00:00
e4fc079080
It can happen that the extra response is to be sent in a different chunk from the rest of the data. At this moment, the client might have already closed the socket causing an `ECONNRESET` error. PR-URL: https://github.com/nodejs/node/pull/4979 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
71 lines
1.7 KiB
JavaScript
71 lines
1.7 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var http = require('http');
|
|
var net = require('net');
|
|
|
|
// If an HTTP server is broken and sends data after the end of the response,
|
|
// node should ignore it and drop the connection.
|
|
// Demos this bug: https://github.com/joyent/node/issues/680
|
|
|
|
var body = 'hello world\r\n';
|
|
var fullResponse =
|
|
'HTTP/1.1 500 Internal Server Error\r\n' +
|
|
'Content-Length: ' + body.length + '\r\n' +
|
|
'Content-Type: text/plain\r\n' +
|
|
'Date: Fri + 18 Feb 2011 06:22:45 GMT\r\n' +
|
|
'Host: 10.20.149.2\r\n' +
|
|
'Access-Control-Allow-Credentials: true\r\n' +
|
|
'Server: badly broken/0.1 (OS NAME)\r\n' +
|
|
'\r\n' +
|
|
body;
|
|
|
|
var gotResponse = false;
|
|
|
|
|
|
var server = net.createServer(function(socket) {
|
|
var postBody = '';
|
|
|
|
socket.setEncoding('utf8');
|
|
|
|
socket.on('data', function(chunk) {
|
|
postBody += chunk;
|
|
|
|
if (postBody.indexOf('\r\n') > -1) {
|
|
socket.write(fullResponse);
|
|
// omg, I wrote the response twice, what a terrible HTTP server I am.
|
|
socket.end(fullResponse);
|
|
}
|
|
});
|
|
|
|
socket.on('error', function(err) {
|
|
assert.equal(err.code, 'ECONNRESET');
|
|
});
|
|
});
|
|
|
|
|
|
server.listen(common.PORT, function() {
|
|
http.get({ port: common.PORT }, function(res) {
|
|
var buffer = '';
|
|
console.log('Got res code: ' + res.statusCode);
|
|
|
|
res.setEncoding('utf8');
|
|
res.on('data', function(chunk) {
|
|
buffer += chunk;
|
|
});
|
|
|
|
res.on('end', function() {
|
|
console.log('Response ended, read ' + buffer.length + ' bytes');
|
|
assert.equal(body, buffer);
|
|
server.close();
|
|
gotResponse = true;
|
|
});
|
|
});
|
|
});
|
|
|
|
|
|
process.on('exit', function() {
|
|
assert.ok(gotResponse);
|
|
});
|
|
|