node/test-http-client-unescaped-path.js at dbdea02a993f7fc40bccdac8a6eec47c67a37a3b - node - Gitea: Git with a cup of tea

jiangcuo/node

mirror of https://github.com/nodejs/node.git synced 2025-05-06 13:09:42 +00:00

Myles Borins 28e9a022df test: wrap assert.fail when passed to callback

Currently there are many instances where assert.fail is directly passed
to a callback for error handling. Unfortunately this will swallow the
error as it is the third argument of assert.fail that sets the message
not the first.

This commit adds a new function to test/common.js that simply wraps
assert.fail and calls it with the provided message.

Tip of the hat to @trott for pointing me in the direction of this.

PR-URL: https://github.com/nodejs/node/pull/3453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

2015-10-24 14:42:41 -07:00

10 lines

263 B

JavaScript

Raw Blame History

 'use strict';
 var common = require('../common');
 var assert = require('assert');
 var http = require('http');
 assert.throws(function() {
   // Path with spaces in it should throw.
   http.get({ path: 'bad path' }, common.fail);
 }, /contains unescaped characters/);