mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 05:21:19 +00:00
060e5f0c00
This makes several changes:
1. Allow path/filename to be passed in as a Buffer on fs methods
2. Add `options.encoding` to fs.readdir, fs.readdirSync, fs.readlink,
fs.readlinkSync and fs.watch.
3. Documentation updates
For 1... it's now possible to do:
```js
fs.open(Buffer('/fs/foo/bar'), 'w+', (err, fd) => { });
```
For 2...
```js
fs.readdir('/fs/foo/bar', {encoding:'hex'}, (err,list) => { });
fs.readdir('/fs/foo/bar', {encoding:'buffer'}, (err, list) => { });
```
encoding can also be passed as a string
```js
fs.readdir('/fs/foo/bar', 'hex', (err,list) => { });
```
The default encoding is set to UTF8 so this addresses the
discrepency that existed previously between fs.readdir and
fs.watch handling filenames differently.
Fixes: https://github.com/nodejs/node/issues/2088
Refs: https://github.com/nodejs/node/issues/3519
PR-URL: https://github.com/nodejs/node/pull/5616
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
37 lines
792 B
JavaScript
37 lines
792 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
// test creating and reading hard link
|
|
const srcPath = path.join(common.tmpDir, 'hardlink-target.txt');
|
|
const dstPath = path.join(common.tmpDir, 'link1.js');
|
|
fs.writeFileSync(srcPath, 'hello world');
|
|
|
|
const callback = function(err) {
|
|
if (err) throw err;
|
|
const dstContent = fs.readFileSync(dstPath, 'utf8');
|
|
assert.strictEqual('hello world', dstContent);
|
|
};
|
|
|
|
fs.link(srcPath, dstPath, common.mustCall(callback));
|
|
|
|
// test error outputs
|
|
|
|
assert.throws(
|
|
function() {
|
|
fs.link();
|
|
},
|
|
/src must be a string or Buffer/
|
|
);
|
|
|
|
assert.throws(
|
|
function() {
|
|
fs.link('abc');
|
|
},
|
|
/dest must be a string or Buffer/
|
|
);
|