mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 11:29:26 +00:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
53 lines
1.4 KiB
JavaScript
53 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
/*
|
|
* The goal of this test is to make sure that when a top-level error
|
|
* handler throws an error following the handling of a previous error,
|
|
* the process reports the error message from the error thrown in the
|
|
* top-level error handler, not the one from the previous error.
|
|
*/
|
|
|
|
require('../common');
|
|
|
|
const domainErrHandlerExMessage = 'exception from domain error handler';
|
|
const internalExMessage = 'You should NOT see me';
|
|
|
|
if (process.argv[2] === 'child') {
|
|
var domain = require('domain');
|
|
var d = domain.create();
|
|
|
|
d.on('error', function() {
|
|
throw new Error(domainErrHandlerExMessage);
|
|
});
|
|
|
|
d.run(function doStuff() {
|
|
process.nextTick(function() {
|
|
throw new Error(internalExMessage);
|
|
});
|
|
});
|
|
} else {
|
|
var fork = require('child_process').fork;
|
|
var assert = require('assert');
|
|
|
|
var child = fork(process.argv[1], ['child'], {silent: true});
|
|
var stderrOutput = '';
|
|
if (child) {
|
|
child.stderr.on('data', function onStderrData(data) {
|
|
stderrOutput += data.toString();
|
|
});
|
|
|
|
child.on('close', function onChildClosed() {
|
|
assert(stderrOutput.indexOf(domainErrHandlerExMessage) !== -1);
|
|
assert(stderrOutput.indexOf(internalExMessage) === -1);
|
|
});
|
|
|
|
child.on('exit', function onChildExited(exitCode, signal) {
|
|
var expectedExitCode = 7;
|
|
var expectedSignal = null;
|
|
|
|
assert.equal(exitCode, expectedExitCode);
|
|
assert.equal(signal, expectedSignal);
|
|
});
|
|
}
|
|
}
|