mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 09:02:40 +00:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
136 lines
4.1 KiB
JavaScript
136 lines
4.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
assert.ok(process.stdout.writable);
|
|
assert.ok(process.stderr.writable);
|
|
// Support legacy API
|
|
assert.equal('number', typeof process.stdout.fd);
|
|
assert.equal('number', typeof process.stderr.fd);
|
|
|
|
assert.doesNotThrow(function() {
|
|
process.once('warning', common.mustCall((warning) => {
|
|
assert(/no such label/.test(warning.message));
|
|
}));
|
|
|
|
console.timeEnd('no such label');
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
console.time('label');
|
|
console.timeEnd('label');
|
|
});
|
|
|
|
// an Object with a custom .inspect() function
|
|
const custom_inspect = { foo: 'bar', inspect: () => { return 'inspect'; } };
|
|
|
|
const stdout_write = global.process.stdout.write;
|
|
const stderr_write = global.process.stderr.write;
|
|
const strings = [];
|
|
const errStrings = [];
|
|
global.process.stdout.write = function(string) {
|
|
strings.push(string);
|
|
};
|
|
global.process.stderr.write = function(string) {
|
|
errStrings.push(string);
|
|
};
|
|
|
|
// test console.log()
|
|
console.log('foo');
|
|
console.log('foo', 'bar');
|
|
console.log('%s %s', 'foo', 'bar', 'hop');
|
|
console.log({slashes: '\\\\'});
|
|
console.log(custom_inspect);
|
|
|
|
// test console.info()
|
|
console.info('foo');
|
|
console.info('foo', 'bar');
|
|
console.info('%s %s', 'foo', 'bar', 'hop');
|
|
console.info({slashes: '\\\\'});
|
|
console.info(custom_inspect);
|
|
|
|
// test console.error()
|
|
console.error('foo');
|
|
console.error('foo', 'bar');
|
|
console.error('%s %s', 'foo', 'bar', 'hop');
|
|
console.error({slashes: '\\\\'});
|
|
console.error(custom_inspect);
|
|
|
|
// test console.warn()
|
|
console.warn('foo');
|
|
console.warn('foo', 'bar');
|
|
console.warn('%s %s', 'foo', 'bar', 'hop');
|
|
console.warn({slashes: '\\\\'});
|
|
console.warn(custom_inspect);
|
|
|
|
// test console.dir()
|
|
console.dir(custom_inspect);
|
|
console.dir(custom_inspect, { showHidden: false });
|
|
console.dir({ foo: { bar: { baz: true } } }, { depth: 0 });
|
|
console.dir({ foo: { bar: { baz: true } } }, { depth: 1 });
|
|
|
|
// test console.trace()
|
|
console.trace('This is a %j %d', { formatted: 'trace' }, 10, 'foo');
|
|
|
|
// test console.time() and console.timeEnd() output
|
|
console.time('label');
|
|
console.timeEnd('label');
|
|
|
|
// verify that Object.prototype properties can be used as labels
|
|
console.time('__proto__');
|
|
console.timeEnd('__proto__');
|
|
console.time('constructor');
|
|
console.timeEnd('constructor');
|
|
console.time('hasOwnProperty');
|
|
console.timeEnd('hasOwnProperty');
|
|
|
|
global.process.stdout.write = stdout_write;
|
|
global.process.stderr.write = stderr_write;
|
|
|
|
// verify that console.timeEnd() doesn't leave dead links
|
|
const timesMapSize = console._times.size;
|
|
console.time('label1');
|
|
console.time('label2');
|
|
console.time('label3');
|
|
console.timeEnd('label1');
|
|
console.timeEnd('label2');
|
|
console.timeEnd('label3');
|
|
assert.strictEqual(console._times.size, timesMapSize);
|
|
|
|
const expectedStrings = [
|
|
'foo', 'foo bar', 'foo bar hop', "{ slashes: '\\\\\\\\' }", 'inspect'
|
|
];
|
|
|
|
for (const expected of expectedStrings) {
|
|
assert.equal(expected + '\n', strings.shift()); // console.log (stdout)
|
|
assert.equal(expected + '\n', errStrings.shift()); // console.error (stderr)
|
|
}
|
|
|
|
for (const expected of expectedStrings) {
|
|
assert.equal(expected + '\n', strings.shift()); // console.info (stdout)
|
|
assert.equal(expected + '\n', errStrings.shift()); // console.warn (stderr)
|
|
}
|
|
|
|
assert.equal("{ foo: 'bar', inspect: [Function] }\n", strings.shift());
|
|
assert.equal("{ foo: 'bar', inspect: [Function] }\n", strings.shift());
|
|
assert.notEqual(-1, strings.shift().indexOf('foo: [Object]'));
|
|
assert.equal(-1, strings.shift().indexOf('baz'));
|
|
assert.ok(/^label: \d+\.\d{3}ms$/.test(strings.shift().trim()));
|
|
assert.ok(/^__proto__: \d+\.\d{3}ms$/.test(strings.shift().trim()));
|
|
assert.ok(/^constructor: \d+\.\d{3}ms$/.test(strings.shift().trim()));
|
|
assert.ok(/^hasOwnProperty: \d+\.\d{3}ms$/.test(strings.shift().trim()));
|
|
|
|
assert.equal('Trace: This is a {"formatted":"trace"} 10 foo',
|
|
errStrings.shift().split('\n').shift());
|
|
|
|
assert.equal(strings.length, 0);
|
|
assert.equal(errStrings.length, 0);
|
|
|
|
assert.throws(() => {
|
|
console.assert(false, 'should throw');
|
|
}, /should throw/);
|
|
|
|
assert.doesNotThrow(() => {
|
|
console.assert(true, 'this should not throw');
|
|
});
|