node/test/parallel/test-cluster-setup-master-argv.js
Myles Borins 28e9a022df test: wrap assert.fail when passed to callback
Currently there are many instances where assert.fail is directly passed
to a callback for error handling. Unfortunately this will swallow the
error as it is the third argument of assert.fail that sets the message
not the first.

This commit adds a new function to test/common.js that simply wraps
assert.fail and calls it with the provided message.

Tip of the hat to @trott for pointing me in the direction of this.

PR-URL: https://github.com/nodejs/node/pull/3453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2015-10-24 14:42:41 -07:00

19 lines
545 B
JavaScript

'use strict';
var common = require('../common');
var assert = require('assert');
var cluster = require('cluster');
setTimeout(common.fail.bind(assert, 'setup not emitted'), 1000).unref();
cluster.on('setup', function() {
var clusterArgs = cluster.settings.args;
var realArgs = process.argv;
assert.equal(clusterArgs[clusterArgs.length - 1],
realArgs[realArgs.length - 1]);
});
assert(process.argv[process.argv.length - 1] !== 'OMG,OMG');
process.argv.push('OMG,OMG');
process.argv.push('OMG,OMG');
cluster.setupMaster();