mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 05:21:19 +00:00
c9c387fdac
Currently we use `{}` for the `lookup` function to find the relevant
resolver to the dns.resolve function. It is preferable to use an
object without a Object.prototype, currently for example you can do
something like:
```js
dns.resolve("google.com", "toString", console.log);
```
And get `[Object undefined]` logged and the callback would never be
called. This is unexpected and strange behavior in my opinion.
In addition, if someone adds a property to `Object.prototype` might
also create unexpected results.
This pull request fixes it, with it an appropriate error is thrown.
PR-URL: https://github.com/nodejs/node/pull/5843
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
44 lines
1.1 KiB
JavaScript
44 lines
1.1 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var dns = require('dns');
|
|
|
|
|
|
// Try resolution without callback
|
|
|
|
dns.lookup(null, function(error, result, addressType) {
|
|
assert.equal(null, result);
|
|
assert.equal(4, addressType);
|
|
});
|
|
|
|
dns.lookup('127.0.0.1', function(error, result, addressType) {
|
|
assert.equal('127.0.0.1', result);
|
|
assert.equal(4, addressType);
|
|
});
|
|
|
|
dns.lookup('::1', function(error, result, addressType) {
|
|
assert.equal('::1', result);
|
|
assert.equal(6, addressType);
|
|
});
|
|
|
|
// Try calling resolve with an unsupported type.
|
|
assert.throws(function() {
|
|
dns.resolve('www.google.com', 'HI');
|
|
}, /Unknown type/);
|
|
|
|
// Try calling resolve with an unsupported type that's an object key
|
|
assert.throws(function() {
|
|
dns.resolve('www.google.com', 'toString');
|
|
}, /Unknown type/);
|
|
|
|
// Windows doesn't usually have an entry for localhost 127.0.0.1 in
|
|
// C:\Windows\System32\drivers\etc\hosts
|
|
// so we disable this test on Windows.
|
|
if (!common.isWindows) {
|
|
dns.reverse('127.0.0.1', function(error, domains) {
|
|
if (error) throw error;
|
|
assert.ok(Array.isArray(domains));
|
|
});
|
|
}
|