mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 07:27:32 +00:00

On UNIX platforms, the debugger doesn't reliably kill the inferior when killed by a signal. Work around that by spawning the debugger in its own process group and killing the process group instead of just the debugger process. This is a hack to get the continuous integration back to green, it doesn't address the underlying issue, which is that the debugger shouldn't leave stray processes behind. Fixes: https://github.com/nodejs/node/issues/7034 PR-URL: https://github.com/nodejs/node/pull/7037 Refs: https://github.com/nodejs/node/pull/3470 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
59 lines
1.8 KiB
JavaScript
59 lines
1.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const spawn = require('child_process').spawn;
|
|
|
|
// FIXME(bnoordhuis) On UNIX platforms, the debugger doesn't reliably kill
|
|
// the inferior when killed by a signal. Work around that by spawning
|
|
// the debugger in its own process group and killing the process group
|
|
// instead of just the debugger process.
|
|
const detached = !common.isWindows;
|
|
|
|
const children = [];
|
|
for (let i = 0; i < 4; i += 1) {
|
|
const port = common.PORT + i;
|
|
const args = [`--debug-port=${port}`, '--interactive', 'debug', __filename];
|
|
const child = spawn(process.execPath, args, { detached, stdio: 'pipe' });
|
|
child.test = { port: port, stdout: '' };
|
|
child.stdout.setEncoding('utf8');
|
|
child.stdout.on('data', function(s) { child.test.stdout += s; update(); });
|
|
child.stdout.pipe(process.stdout);
|
|
child.stderr.pipe(process.stderr);
|
|
children.push(child);
|
|
}
|
|
|
|
function update() {
|
|
// Debugger prints relative paths except on Windows.
|
|
const filename = path.basename(__filename);
|
|
|
|
let ready = 0;
|
|
for (const child of children)
|
|
ready += RegExp(`break in .*?${filename}:1`).test(child.test.stdout);
|
|
|
|
if (ready === children.length)
|
|
for (const child of children)
|
|
kill(child);
|
|
}
|
|
|
|
function kill(child) {
|
|
if (!detached)
|
|
return child.kill();
|
|
|
|
try {
|
|
process.kill(-child.pid); // Kill process group.
|
|
} catch (e) {
|
|
assert.strictEqual(e.code, 'ESRCH'); // Already gone.
|
|
}
|
|
}
|
|
|
|
process.on('exit', function() {
|
|
for (const child of children) {
|
|
const one = RegExp(`Debugger listening on port ${child.test.port}`);
|
|
const two = RegExp(`connecting to 127.0.0.1:${child.test.port}`);
|
|
assert(one.test(child.test.stdout));
|
|
assert(two.test(child.test.stdout));
|
|
}
|
|
});
|