mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 01:31:27 +00:00
d8f73385e2
- Throw getPathFromURL() and nullCheck() errors synchronously instead of deferring them to the next tick, since we already throw validatePath() errors synchronously. - Merge nullCheck() into validatePath() - Never throws in `fs.exists()`, instead, invoke the callback with false, or emit a warning when the callback is not a function. This is to bring it inline with fs.existsSync(), which never throws. - Updates the comment of rethrow() - Throw ERR_INVALID_ARG_VALUE for null checks PR-URL: https://github.com/nodejs/node/pull/18308 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
104 lines
2.8 KiB
JavaScript
104 lines
2.8 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const URL = require('url').URL;
|
|
|
|
function pathToFileURL(p) {
|
|
if (!path.isAbsolute(p))
|
|
throw new Error('Path must be absolute');
|
|
if (common.isWindows && p.startsWith('\\\\'))
|
|
p = p.slice(2);
|
|
return new URL(`file://${p}`);
|
|
}
|
|
|
|
const p = path.resolve(fixtures.fixturesDir, 'a.js');
|
|
const url = pathToFileURL(p);
|
|
|
|
assert(url instanceof URL);
|
|
|
|
// Check that we can pass in a URL object successfully
|
|
fs.readFile(url, common.mustCall((err, data) => {
|
|
assert.ifError(err);
|
|
assert(Buffer.isBuffer(data));
|
|
}));
|
|
|
|
// Check that using a non file:// URL reports an error
|
|
const httpUrl = new URL('http://example.org');
|
|
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(httpUrl, common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_URL_SCHEME',
|
|
type: TypeError,
|
|
message: 'The URL must be of scheme file'
|
|
});
|
|
|
|
// pct-encoded characters in the path will be decoded and checked
|
|
if (common.isWindows) {
|
|
// encoded back and forward slashes are not permitted on windows
|
|
['%2f', '%2F', '%5c', '%5C'].forEach((i) => {
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(new URL(`file:///c:/tmp/${i}`), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_PATH',
|
|
type: TypeError,
|
|
message: 'File URL path must not include encoded \\ or / characters'
|
|
}
|
|
);
|
|
});
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(new URL('file:///c:/tmp/%00test'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
type: Error,
|
|
message: 'The argument \'path\' must be a string or Uint8Array without ' +
|
|
'null bytes. Received \'c:/tmp/\\u0000test\''
|
|
}
|
|
);
|
|
} else {
|
|
// encoded forward slashes are not permitted on other platforms
|
|
['%2f', '%2F'].forEach((i) => {
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(new URL(`file:///c:/tmp/${i}`), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_PATH',
|
|
type: TypeError,
|
|
message: 'File URL path must not include encoded / characters'
|
|
});
|
|
});
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(new URL('file://hostname/a/b/c'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_FILE_URL_HOST',
|
|
type: TypeError,
|
|
message: `File URL host must be "localhost" or empty on ${os.platform()}`
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => {
|
|
fs.readFile(new URL('file:///tmp/%00test'), common.mustNotCall());
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
type: Error,
|
|
message: 'The argument \'path\' must be a string or Uint8Array without ' +
|
|
'null bytes. Received \'/tmp/\\u0000test\''
|
|
}
|
|
);
|
|
}
|