node/test/parallel/test-gc-tls-external-memory.js
Anna Henningsen d4cdb2ce66
test: refactor test-gc-tls-external-memory
- Don’t use network connections, we don’t need them and
  they add more native objects into the mix when we care
  about other kinds of native objects.
- Run GC only once every 64 iterations – this cuts down
  running time from 4 s to 400 ms.
- Use `common.mustCall()` for the `connect()` handler.
- Make sure that the TLS sockets do get garbage collected,
  since the test would otherwise also pass if they remain
  alive indefinitely.

PR-URL: https://github.com/nodejs/node/pull/22651
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-09-05 12:44:42 +02:00

50 lines
1.4 KiB
JavaScript

'use strict';
// Flags: --expose-gc
// Tests that memoryUsage().external doesn't go negative
// when a lot tls connections are opened and closed
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const makeDuplexPair = require('../common/duplexpair');
const onGC = require('../common/ongc');
const assert = require('assert');
const tls = require('tls');
// Payload doesn't matter. We just need to have the tls
// connection try and connect somewhere.
const dummyPayload = Buffer.alloc(10000, 'yolo');
let runs = 0;
// Count garbage-collected TLS sockets.
let gced = 0;
function ongc() { gced++; }
connect();
function connect() {
if (runs % 64 === 0)
global.gc();
const externalMemoryUsage = process.memoryUsage().external;
assert(externalMemoryUsage >= 0, `${externalMemoryUsage} < 0`);
if (runs++ === 512) {
// Make sure at least half the TLS sockets have been gargbage collected
// (so that this test can actually check what it's testing):
assert(gced >= 256, `${gced} < 256`);
return;
}
const { clientSide, serverSide } = makeDuplexPair();
const tlsSocket = tls.connect({ socket: clientSide });
tlsSocket.on('error', common.mustCall(connect));
onGC(tlsSocket, { ongc });
// Use setImmediate so that we don't trigger the error within the same
// event loop tick.
setImmediate(() => serverSide.write(dummyPayload));
}