mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 00:19:41 +00:00

In Streams3 the 'readable' event/.read() method had a lower precedence than the `'data'` event that made them impossible to use them together. This make `.resume()` a no-op if there is a listener for the `'readable'` event, making the stream non-flowing if there is a `'data'` listener. Fixes: https://github.com/nodejs/node/issues/18058 PR-URL: https://github.com/nodejs/node/pull/18994 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
53 lines
1.2 KiB
JavaScript
53 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const helloWorld = 'Hello World!';
|
|
const helloAgainLater = 'Hello again later!';
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.writeHead(200, {
|
|
'Content-Length': '' + (helloWorld.length + helloAgainLater.length)
|
|
});
|
|
res.write(helloWorld);
|
|
|
|
// we need to make sure the data is flushed
|
|
setTimeout(() => {
|
|
res.end(helloAgainLater);
|
|
}, common.platformTimeout(10));
|
|
}).listen(0, function() {
|
|
const opts = {
|
|
hostname: 'localhost',
|
|
port: server.address().port,
|
|
path: '/'
|
|
};
|
|
|
|
const expectedData = [helloWorld, helloAgainLater];
|
|
const expectedRead = [helloWorld, null, helloAgainLater, null];
|
|
|
|
const req = http.request(opts, (res) => {
|
|
res.on('error', common.mustNotCall);
|
|
|
|
res.on('readable', common.mustCall(() => {
|
|
let data;
|
|
|
|
do {
|
|
data = res.read();
|
|
assert.strictEqual(data, expectedRead.shift());
|
|
} while (data !== null);
|
|
}, 2));
|
|
|
|
res.setEncoding('utf8');
|
|
res.on('data', common.mustCall((data) => {
|
|
assert.strictEqual(data, expectedData.shift());
|
|
}, 2));
|
|
|
|
res.on('end', common.mustCall(() => {
|
|
server.close();
|
|
}));
|
|
});
|
|
|
|
req.end();
|
|
});
|