mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 09:52:26 +00:00
cef144421c
I added a new custom ESLint rule to fix these problems. We have a lot of replaceable codes with primordials. Accessing built-in objects is restricted by existing rule (no-restricted-globals), but accessing property in the built-in objects is not restricted right now. We manually review codes that can be replaced by primordials, but there's a lot of code that actually needs to be fixed. We have often made pull requests to replace the primordials with. Restrict accessing global built-in objects such as `Promise`. Restrict calling static methods such as `Array.from` or `Symbol.for`. Don't restrict prototype methods to prevent false-positive. PR-URL: https://github.com/nodejs/node/pull/35448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com>
59 lines
1.2 KiB
JavaScript
59 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const {
|
|
Symbol,
|
|
Date,
|
|
} = primordials;
|
|
|
|
const { setUnrefTimeout } = require('internal/timers');
|
|
const { PerformanceEntry, notify } = internalBinding('performance');
|
|
|
|
let nowCache;
|
|
let utcCache;
|
|
|
|
function nowDate() {
|
|
if (!nowCache) cache();
|
|
return nowCache;
|
|
}
|
|
|
|
function utcDate() {
|
|
if (!utcCache) cache();
|
|
return utcCache;
|
|
}
|
|
|
|
function cache() {
|
|
const d = new Date();
|
|
nowCache = d.valueOf();
|
|
utcCache = d.toUTCString();
|
|
setUnrefTimeout(resetCache, 1000 - d.getMilliseconds());
|
|
}
|
|
|
|
function resetCache() {
|
|
nowCache = undefined;
|
|
utcCache = undefined;
|
|
}
|
|
|
|
class HttpRequestTiming extends PerformanceEntry {
|
|
constructor(statistics) {
|
|
super();
|
|
this.name = 'HttpRequest';
|
|
this.entryType = 'http';
|
|
const startTime = statistics.startTime;
|
|
const diff = process.hrtime(startTime);
|
|
this.duration = diff[0] * 1000 + diff[1] / 1e6;
|
|
this.startTime = startTime[0] * 1000 + startTime[1] / 1e6;
|
|
}
|
|
}
|
|
|
|
function emitStatistics(statistics) {
|
|
notify('http', new HttpRequestTiming(statistics));
|
|
}
|
|
|
|
module.exports = {
|
|
kOutHeaders: Symbol('kOutHeaders'),
|
|
kNeedDrain: Symbol('kNeedDrain'),
|
|
nowDate,
|
|
utcDate,
|
|
emitStatistics
|
|
};
|