mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
65 lines
1.6 KiB
JavaScript
65 lines
1.6 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
// This tests interoperability between TextEncoder and TextDecoder with
|
|
// Node.js util.inspect and Buffer APIs
|
|
|
|
'use strict';
|
|
|
|
require('../common');
|
|
|
|
const assert = require('assert');
|
|
const { customInspectSymbol: inspect } = require('internal/util');
|
|
|
|
const encoded = Buffer.from([0xef, 0xbb, 0xbf, 0x74, 0x65,
|
|
0x73, 0x74, 0xe2, 0x82, 0xac]);
|
|
|
|
// Make Sure TextEncoder exists
|
|
assert(TextEncoder);
|
|
|
|
// Test TextEncoder
|
|
{
|
|
const enc = new TextEncoder();
|
|
assert.strictEqual(enc.encoding, 'utf-8');
|
|
assert(enc);
|
|
const buf = enc.encode('\ufefftest€');
|
|
assert.strictEqual(Buffer.compare(buf, encoded), 0);
|
|
}
|
|
|
|
{
|
|
const enc = new TextEncoder();
|
|
const buf = enc.encode();
|
|
assert.strictEqual(buf.length, 0);
|
|
}
|
|
|
|
{
|
|
const enc = new TextEncoder();
|
|
const buf = enc.encode(undefined);
|
|
assert.strictEqual(buf.length, 0);
|
|
}
|
|
|
|
{
|
|
const inspectFn = TextEncoder.prototype[inspect];
|
|
const encodeFn = TextEncoder.prototype.encode;
|
|
const encodingGetter =
|
|
Object.getOwnPropertyDescriptor(TextEncoder.prototype, 'encoding').get;
|
|
|
|
const instance = new TextEncoder();
|
|
|
|
const expectedError = {
|
|
code: 'ERR_INVALID_THIS',
|
|
name: 'TypeError',
|
|
message: 'Value of "this" must be of type TextEncoder'
|
|
};
|
|
|
|
inspectFn.call(instance, Infinity, {});
|
|
encodeFn.call(instance);
|
|
encodingGetter.call(instance);
|
|
|
|
const invalidThisArgs = [{}, [], true, 1, '', new TextDecoder()];
|
|
invalidThisArgs.forEach((i) => {
|
|
assert.throws(() => inspectFn.call(i, Infinity, {}), expectedError);
|
|
assert.throws(() => encodeFn.call(i), expectedError);
|
|
assert.throws(() => encodingGetter.call(i), expectedError);
|
|
});
|
|
}
|