node/test/parallel/test-validators.js
Antoine du Hamel b4a7d9f987
lib: make validateObject less affected by prototype tampering
PR-URL: https://github.com/nodejs/node/pull/42929
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-07-11 09:48:41 +01:00

157 lines
4.2 KiB
JavaScript

// Flags: --expose-internals
'use strict';
require('../common');
const assert = require('assert');
const {
validateArray,
validateBoolean,
validateInteger,
validateNumber,
validateObject,
validateString,
validateInt32,
validateUint32,
} = require('internal/validators');
const { MAX_SAFE_INTEGER, MIN_SAFE_INTEGER } = Number;
const outOfRangeError = {
code: 'ERR_OUT_OF_RANGE',
name: 'RangeError',
};
const invalidArgTypeError = {
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
};
const invalidArgValueError = {
code: 'ERR_INVALID_ARG_VALUE',
name: 'TypeError',
};
{
// validateInteger tests.
// validateInteger() defaults to validating safe integers.
validateInteger(MAX_SAFE_INTEGER, 'foo');
validateInteger(MIN_SAFE_INTEGER, 'foo');
assert.throws(() => {
validateInteger(MAX_SAFE_INTEGER + 1, 'foo');
}, outOfRangeError);
assert.throws(() => {
validateInteger(MIN_SAFE_INTEGER - 1, 'foo');
}, outOfRangeError);
// validateInteger() works with unsafe integers.
validateInteger(MAX_SAFE_INTEGER + 1, 'foo', 0, MAX_SAFE_INTEGER + 1);
validateInteger(MIN_SAFE_INTEGER - 1, 'foo', MIN_SAFE_INTEGER - 1);
// validateInt32() and validateUint32()
[
Symbol(), 1n, {}, [], false, true, undefined, null, () => {}, '', '1',
].forEach((val) => assert.throws(() => validateInt32(val, 'name'), {
code: 'ERR_INVALID_ARG_TYPE'
}));
[
2147483647 + 1, -2147483648 - 1, NaN,
].forEach((val) => assert.throws(() => validateInt32(val, 'name'), {
code: 'ERR_OUT_OF_RANGE'
}));
[
0, 1, -1,
].forEach((val) => validateInt32(val, 'name'));
[
Symbol(), 1n, {}, [], false, true, undefined, null, () => {}, '', '1',
].forEach((val) => assert.throws(() => validateUint32(val, 'name'), {
code: 'ERR_INVALID_ARG_TYPE'
}));
[
4294967296, -1, NaN,
].forEach((val) => assert.throws(() => validateUint32(val, 'name'), {
code: 'ERR_OUT_OF_RANGE'
}));
[
0, 1,
].forEach((val) => validateUint32(val, 'name'));
}
{
// validateArray tests.
validateArray([], 'foo');
validateArray([1, 2, 3], 'foo');
[undefined, null, true, false, 0, 0.0, 42, '', 'string', {}]
.forEach((val) => {
assert.throws(() => {
validateArray(val, 'foo');
}, invalidArgTypeError);
});
validateArray([1], 'foo', 1);
assert.throws(() => {
validateArray([], 'foo', 1);
}, invalidArgValueError);
}
{
// validateBoolean tests.
validateBoolean(true, 'foo');
validateBoolean(false, 'foo');
[undefined, null, 0, 0.0, 42, '', 'string', {}, []].forEach((val) => {
assert.throws(() => {
validateBoolean(val, 'foo');
}, invalidArgTypeError);
});
}
{
// validateObject tests.
Object.prototype.nullable = true;
Object.prototype.allowArray = true;
Object.prototype.allowFunction = true;
validateObject({}, 'foo');
validateObject({ a: 42, b: 'foo' }, 'foo');
[undefined, null, true, false, 0, 0.0, 42, '', 'string', [], () => {}]
.forEach((val) => {
assert.throws(() => {
validateObject(val, 'foo');
}, invalidArgTypeError);
});
// validateObject options tests:
validateObject(null, 'foo', { nullable: true });
validateObject([], 'foo', { allowArray: true });
validateObject(() => {}, 'foo', { allowFunction: true });
// validateObject should not be affected by Object.prototype tampering.
assert.throws(() => validateObject(null, 'foo', { allowArray: true }), invalidArgTypeError);
assert.throws(() => validateObject([], 'foo', { nullable: true }), invalidArgTypeError);
assert.throws(() => validateObject(() => {}, 'foo', { nullable: true }), invalidArgTypeError);
delete Object.prototype.nullable;
delete Object.prototype.allowArray;
delete Object.prototype.allowFunction;
}
{
// validateString type validation.
[
-1, {}, [], false, true,
1, Infinity, -Infinity, NaN,
undefined, null, 1.1,
].forEach((i) => assert.throws(() => validateString(i, 'name'), {
code: 'ERR_INVALID_ARG_TYPE'
}));
}
{
// validateNumber type validation.
[
'a', {}, [], false, true,
undefined, null, '', ' ', '0x',
'-0x1', '-0o1', '-0b1', '0o', '0b',
].forEach((i) => assert.throws(() => validateNumber(i, 'name'), {
code: 'ERR_INVALID_ARG_TYPE'
}));
}