mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
54 lines
1.3 KiB
JavaScript
54 lines
1.3 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
getSystemErrorName,
|
|
_errnoException
|
|
} = require('util');
|
|
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const uv = internalBinding('uv');
|
|
const keys = Object.keys(uv);
|
|
|
|
keys.forEach((key) => {
|
|
if (!key.startsWith('UV_'))
|
|
return;
|
|
|
|
const err = _errnoException(uv[key], 'test');
|
|
const name = uv.errname(uv[key]);
|
|
assert.strictEqual(getSystemErrorName(uv[key]), name);
|
|
assert.strictEqual(err.code, name);
|
|
assert.strictEqual(err.code, getSystemErrorName(err.errno));
|
|
assert.strictEqual(err.message, `test ${name}`);
|
|
});
|
|
|
|
function runTest(fn) {
|
|
['test', {}, []].forEach((err) => {
|
|
assert.throws(
|
|
() => fn(err),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "err" argument must be of type number.' +
|
|
common.invalidArgTypeHelper(err)
|
|
});
|
|
});
|
|
|
|
[0, 1, Infinity, -Infinity, NaN].forEach((err) => {
|
|
assert.throws(
|
|
() => fn(err),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "err" is out of range. ' +
|
|
'It must be a negative integer. ' +
|
|
`Received ${err}`
|
|
});
|
|
});
|
|
}
|
|
|
|
runTest(_errnoException);
|
|
runTest(getSystemErrorName);
|