mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
49 lines
1.2 KiB
JavaScript
49 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
// This tests the errors thrown from TLSSocket.prototype.setServername
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const { connect, TLSSocket } = require('tls');
|
|
const makeDuplexPair = require('../common/duplexpair');
|
|
const { clientSide, serverSide } = makeDuplexPair();
|
|
|
|
const key = fixtures.readKey('agent1-key.pem');
|
|
const cert = fixtures.readKey('agent1-cert.pem');
|
|
const ca = fixtures.readKey('ca1-cert.pem');
|
|
|
|
const client = connect({
|
|
socket: clientSide,
|
|
ca,
|
|
host: 'agent1' // Hostname from certificate
|
|
});
|
|
|
|
[undefined, null, 1, true, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
client.setServername(value);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "name" argument must be of type string.' +
|
|
common.invalidArgTypeHelper(value)
|
|
});
|
|
});
|
|
|
|
const server = new TLSSocket(serverSide, {
|
|
isServer: true,
|
|
key,
|
|
cert,
|
|
ca
|
|
});
|
|
|
|
assert.throws(() => {
|
|
server.setServername('localhost');
|
|
}, {
|
|
code: 'ERR_TLS_SNI_FROM_SERVER',
|
|
message: 'Cannot issue SNI from a TLS server-side socket'
|
|
});
|