mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00

This is a semver-major change that resolves DEP0018. All users that have set an unhandledRejection hook or set a non-default value for the --unhandled-rejections flag will see no change in behavior after this change. Refs: https://nodejs.org/dist/latest/docs/api/deprecations.html#deprecations_dep0018_unhandled_promise_rejections PR-URL: https://github.com/nodejs/node/pull/33021 Fixes: https://github.com/nodejs/node/issues/20392 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
54 lines
1.6 KiB
JavaScript
54 lines
1.6 KiB
JavaScript
// Flags: --unhandled-rejections=throw
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const Countdown = require('../common/countdown');
|
|
const assert = require('assert');
|
|
|
|
// Verify that unhandled rejections always trigger uncaught exceptions instead
|
|
// of triggering unhandled rejections.
|
|
|
|
const err1 = new Error('One');
|
|
const err2 = new Error(
|
|
'This error originated either by throwing ' +
|
|
'inside of an async function without a catch block, or by rejecting a ' +
|
|
'promise which was not handled with .catch(). The promise rejected with the' +
|
|
' reason "null".'
|
|
);
|
|
err2.code = 'ERR_UNHANDLED_REJECTION';
|
|
Object.defineProperty(err2, 'name', {
|
|
value: 'UnhandledPromiseRejection',
|
|
writable: true,
|
|
configurable: true
|
|
});
|
|
|
|
const errors = [err1, err2];
|
|
const identical = [true, false];
|
|
|
|
const ref = new Promise(() => {
|
|
throw err1;
|
|
});
|
|
// Explicitly reject `null`.
|
|
Promise.reject(null);
|
|
|
|
process.on('warning', common.mustNotCall('warning'));
|
|
// If we add an unhandledRejection handler, the exception won't be thrown
|
|
// process.on('unhandledRejection', common.mustCall(2));
|
|
process.on('rejectionHandled', common.mustNotCall('rejectionHandled'));
|
|
process.on('exit', assert.strictEqual.bind(null, 0));
|
|
|
|
const timer = setTimeout(() => console.log(ref), 1000);
|
|
|
|
const counter = new Countdown(2, () => {
|
|
clearTimeout(timer);
|
|
});
|
|
|
|
process.on('uncaughtException', common.mustCall((err, origin) => {
|
|
counter.dec();
|
|
assert.strictEqual(origin, 'unhandledRejection', err);
|
|
const knownError = errors.shift();
|
|
assert.deepStrictEqual(err, knownError);
|
|
// Check if the errors are reference equal.
|
|
assert(identical.shift() ? err === knownError : err !== knownError);
|
|
}, 2));
|