mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
if (!common.isMainThread)
|
|
common.skip('process.chdir is not available in Workers');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
process.chdir('..');
|
|
assert.notStrictEqual(process.cwd(), __dirname);
|
|
process.chdir(__dirname);
|
|
assert.strictEqual(process.cwd(), __dirname);
|
|
|
|
let dirName;
|
|
if (process.versions.icu) {
|
|
// ICU is available, use characters that could possibly be decomposed
|
|
dirName = 'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3';
|
|
} else {
|
|
// ICU is unavailable, use characters that can't be decomposed
|
|
dirName = 'weird \ud83d\udc04 characters \ud83d\udc05';
|
|
}
|
|
const dir = path.resolve(tmpdir.path, dirName);
|
|
|
|
// Make sure that the tmp directory is clean
|
|
tmpdir.refresh();
|
|
|
|
fs.mkdirSync(dir);
|
|
process.chdir(dir);
|
|
assert.strictEqual(process.cwd().normalize(), dir.normalize());
|
|
|
|
process.chdir('..');
|
|
assert.strictEqual(process.cwd().normalize(),
|
|
path.resolve(tmpdir.path).normalize());
|
|
|
|
const err = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /The "directory" argument must be of type string/
|
|
};
|
|
assert.throws(function() { process.chdir({}); }, err);
|
|
assert.throws(function() { process.chdir(); }, err);
|