mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
924 B
JavaScript
38 lines
924 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
// We use the lower-level API here
|
|
server.on('stream', common.mustCall(onStream));
|
|
|
|
function onStream(stream, headers, flags) {
|
|
stream.close();
|
|
|
|
assert.throws(() => {
|
|
stream.additionalHeaders({
|
|
':status': 123,
|
|
'abc': 123
|
|
});
|
|
}, { code: 'ERR_HTTP2_INVALID_STREAM' });
|
|
}
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
req.on('headers', common.mustNotCall());
|
|
req.on('close', common.mustCall(() => {
|
|
assert.strictEqual(h2.constants.NGHTTP2_NO_ERROR, req.rstCode);
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.on('response', common.mustNotCall());
|
|
}));
|