mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
54 lines
1.3 KiB
JavaScript
54 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream) => {
|
|
stream.respond();
|
|
stream.end('ok');
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const nextID = 2 ** 31 - 1;
|
|
|
|
client.on('connect', () => {
|
|
client.setNextStreamID(nextID);
|
|
|
|
assert.strictEqual(client.state.nextStreamID, nextID);
|
|
|
|
const countdown = new Countdown(2, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
{
|
|
// This one will be ok
|
|
const req = client.request();
|
|
assert.strictEqual(req.id, nextID);
|
|
|
|
req.on('error', common.mustNotCall());
|
|
req.resume();
|
|
req.on('end', () => countdown.dec());
|
|
}
|
|
|
|
{
|
|
// This one will error because there are no more stream IDs available
|
|
const req = client.request();
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_OUT_OF_STREAMS',
|
|
name: 'Error',
|
|
message:
|
|
'No stream ID is available because maximum stream ID has been reached'
|
|
}));
|
|
req.on('error', () => countdown.dec());
|
|
}
|
|
});
|
|
}));
|