mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
52 lines
1.2 KiB
JavaScript
52 lines
1.2 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
|
|
const {
|
|
assertIsObject,
|
|
assertWithinRange,
|
|
sessionName
|
|
} = require('internal/http2/util');
|
|
|
|
// Code coverage for sessionName utility function
|
|
assert.strictEqual(sessionName(0), 'server');
|
|
assert.strictEqual(sessionName(1), 'client');
|
|
[2, '', 'test', {}, [], true].forEach((i) => {
|
|
assert.strictEqual(sessionName(2), '<invalid>');
|
|
});
|
|
|
|
// Code coverage for assertWithinRange function
|
|
assert.throws(
|
|
() => assertWithinRange('test', -1),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
|
|
name: 'RangeError',
|
|
message: 'Invalid value for setting "test": -1'
|
|
});
|
|
|
|
assertWithinRange('test', 1);
|
|
|
|
assert.throws(
|
|
() => assertIsObject('foo', 'test'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "test" argument must be of type object. Received ' +
|
|
"type string ('foo')"
|
|
});
|
|
|
|
assert.throws(
|
|
() => assertIsObject('foo', 'test', ['Date']),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "test" argument must be an instance of Date. Received type ' +
|
|
"string ('foo')"
|
|
});
|
|
|
|
assertIsObject({}, 'test');
|