mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
62 lines
1.4 KiB
JavaScript
62 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream) => {
|
|
stream.respond();
|
|
stream.end('ok');
|
|
});
|
|
|
|
const types = {
|
|
boolean: true,
|
|
function: () => {},
|
|
number: 1,
|
|
object: {},
|
|
array: [],
|
|
null: null,
|
|
symbol: Symbol('test')
|
|
};
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
client.on('connect', () => {
|
|
const outOfRangeNum = 2 ** 32;
|
|
assert.throws(
|
|
() => client.setNextStreamID(outOfRangeNum),
|
|
{
|
|
name: 'RangeError',
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
message: 'The value of "id" is out of range.' +
|
|
' It must be > 0 and <= 4294967295. Received ' + outOfRangeNum
|
|
}
|
|
);
|
|
|
|
// Should throw if something other than number is passed to setNextStreamID
|
|
Object.entries(types).forEach(([type, value]) => {
|
|
if (type === 'number') {
|
|
return;
|
|
}
|
|
|
|
assert.throws(
|
|
() => client.setNextStreamID(value),
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "id" argument must be of type number.' +
|
|
common.invalidArgTypeHelper(value)
|
|
}
|
|
);
|
|
});
|
|
|
|
server.close();
|
|
client.close();
|
|
});
|
|
}));
|