node/test/parallel/test-fs-write-stream-autoclose-option.js
Robert Nagy 568fdfb165 fs: fix WriteStream autoClose order
WriteStream autoClose was implemented by manually
calling .destroy() instead of using autoDestroy
and callback. This caused some invariants related
to order of events to be broken.

Fixes: https://github.com/nodejs/node/issues/31776

PR-URL: https://github.com/nodejs/node/pull/31790
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2020-02-16 14:33:20 +01:00

60 lines
1.8 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');
const tmpdir = require('../common/tmpdir');
const file = path.join(tmpdir.path, 'write-autoclose-opt1.txt');
tmpdir.refresh();
let stream = fs.createWriteStream(file, { flags: 'w+', autoClose: false });
stream.write('Test1');
stream.end();
stream.on('finish', common.mustCall(function() {
stream.on('close', common.mustNotCall());
process.nextTick(common.mustCall(function() {
assert.strictEqual(stream.closed, false);
assert.notStrictEqual(stream.fd, null);
next();
}));
}));
function next() {
// This will tell us if the fd is usable again or not
stream = fs.createWriteStream(null, { fd: stream.fd, start: 0 });
stream.write('Test2');
stream.end();
stream.on('finish', common.mustCall(function() {
assert.strictEqual(stream.closed, false);
stream.on('close', common.mustCall(function() {
assert.strictEqual(stream.fd, null);
assert.strictEqual(stream.closed, true);
process.nextTick(next2);
}));
}));
}
function next2() {
// This will test if after reusing the fd data is written properly
fs.readFile(file, function(err, data) {
assert.ifError(err);
assert.strictEqual(data.toString(), 'Test2');
process.nextTick(common.mustCall(next3));
});
}
function next3() {
// This is to test success scenario where autoClose is true
const stream = fs.createWriteStream(file, { autoClose: true });
stream.write('Test3');
stream.end();
stream.on('finish', common.mustCall(function() {
assert.strictEqual(stream.closed, false);
stream.on('close', common.mustCall(function() {
assert.strictEqual(stream.fd, null);
assert.strictEqual(stream.closed, true);
}));
}));
}