mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
1019 B
JavaScript
38 lines
1019 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { promisify } = require('util');
|
|
|
|
const read = promisify(fs.read);
|
|
const write = promisify(fs.write);
|
|
const exists = promisify(fs.exists);
|
|
|
|
{
|
|
const fd = fs.openSync(__filename, 'r');
|
|
read(fd, Buffer.alloc(1024), 0, 1024, null).then(common.mustCall((obj) => {
|
|
assert.strictEqual(typeof obj.bytesRead, 'number');
|
|
assert(obj.buffer instanceof Buffer);
|
|
fs.closeSync(fd);
|
|
}));
|
|
}
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
{
|
|
const filename = path.join(tmpdir.path, 'write-promise.txt');
|
|
const fd = fs.openSync(filename, 'w');
|
|
write(fd, Buffer.from('foobar')).then(common.mustCall((obj) => {
|
|
assert.strictEqual(typeof obj.bytesWritten, 'number');
|
|
assert.strictEqual(obj.buffer.toString(), 'foobar');
|
|
fs.closeSync(fd);
|
|
}));
|
|
}
|
|
|
|
{
|
|
exists(__filename).then(common.mustCall((x) => {
|
|
assert.strictEqual(x, true);
|
|
}));
|
|
}
|