mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
dd52c05046
Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.
Unnecessarily using deep comparisons adds confusion.
This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.
For reference, an ESTree literal is defined as follows.
extend interface Literal <: Expression {
type: "Literal";
value: string | boolean | null | number | RegExp | bigint;
}
The value `undefined` is an `Identifier` with `name: 'undefined'`.
PR-URL: https://github.com/nodejs/node/pull/40634
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
36 lines
1015 B
JavaScript
36 lines
1015 B
JavaScript
'use strict';
|
|
|
|
// This test makes sure that `readFile()` always reads from the current
|
|
// position of the file, instead of reading from the beginning of the file.
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const { writeFileSync } = require('fs');
|
|
const { open } = require('fs').promises;
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
const fn = path.join(tmpdir.path, 'test.txt');
|
|
writeFileSync(fn, 'Hello World');
|
|
|
|
async function readFileTest() {
|
|
const handle = await open(fn, 'r');
|
|
|
|
/* Read only five bytes, so that the position moves to five. */
|
|
const buf = Buffer.alloc(5);
|
|
const { bytesRead } = await handle.read(buf, 0, 5, null);
|
|
assert.strictEqual(bytesRead, 5);
|
|
assert.strictEqual(buf.toString(), 'Hello');
|
|
|
|
/* readFile() should read from position five, instead of zero. */
|
|
assert.strictEqual((await handle.readFile()).toString(), ' World');
|
|
|
|
await handle.close();
|
|
}
|
|
|
|
|
|
readFileTest()
|
|
.then(common.mustCall());
|