mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
5100e84f4b
Sometimes, the expected warnings were not emitted. To harden the test: - Instead of relying on a timeout that raced against the file being opened, wait until the file is opened and then schedule GC after that. - Explicitly keep the event loop alive for one turn to make sure the warning is being seen. PR-URL: https://github.com/nodejs/node/pull/31687 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
42 lines
1.3 KiB
JavaScript
42 lines
1.3 KiB
JavaScript
// Flags: --expose-gc --no-warnings
|
|
'use strict';
|
|
|
|
// Test that a runtime warning is emitted when a FileHandle object
|
|
// is allowed to close on garbage collection. In the future, this
|
|
// test should verify that closing on garbage collection throws a
|
|
// process fatal exception.
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { promises: fs } = require('fs');
|
|
|
|
const warning =
|
|
'Closing a FileHandle object on garbage collection is deprecated. ' +
|
|
'Please close FileHandle objects explicitly using ' +
|
|
'FileHandle.prototype.close(). In the future, an error will be ' +
|
|
'thrown if a file descriptor is closed during garbage collection.';
|
|
|
|
async function doOpen() {
|
|
const fh = await fs.open(__filename);
|
|
|
|
common.expectWarning({
|
|
Warning: [[`Closing file descriptor ${fh.fd} on garbage collection`]],
|
|
DeprecationWarning: [[warning, 'DEP0137']]
|
|
});
|
|
|
|
return fh;
|
|
}
|
|
|
|
doOpen().then(common.mustCall((fd) => {
|
|
assert.strictEqual(typeof fd, 'object');
|
|
})).then(common.mustCall(() => {
|
|
setImmediate(() => {
|
|
// The FileHandle should be out-of-scope and no longer accessed now.
|
|
global.gc();
|
|
|
|
// Wait an extra event loop turn, as the warning is emitted from the
|
|
// native layer in an unref()'ed setImmediate() callback.
|
|
setImmediate(common.mustCall());
|
|
});
|
|
}));
|