mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
49 lines
1.1 KiB
JavaScript
49 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const tempFile = path.join(tmpdir.path, 'fs-non-number-arguments-throw');
|
|
|
|
tmpdir.refresh();
|
|
fs.writeFileSync(tempFile, 'abc\ndef');
|
|
|
|
// A sanity check when using numbers instead of strings
|
|
const sanity = 'def';
|
|
const saneEmitter = fs.createReadStream(tempFile, { start: 4, end: 6 });
|
|
|
|
assert.throws(
|
|
() => {
|
|
fs.createReadStream(tempFile, { start: '4', end: 6 });
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
|
|
assert.throws(
|
|
() => {
|
|
fs.createReadStream(tempFile, { start: 4, end: '6' });
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
|
|
assert.throws(
|
|
() => {
|
|
fs.createWriteStream(tempFile, { start: '4' });
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
});
|
|
|
|
saneEmitter.on('data', common.mustCall(function(data) {
|
|
assert.strictEqual(
|
|
sanity, data.toString('utf8'),
|
|
`read ${data.toString('utf8')} instead of ${sanity}`);
|
|
}));
|