mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 17:03:34 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
770 B
JavaScript
38 lines
770 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const EventEmitter = require('events');
|
|
const util = require('util');
|
|
|
|
const EE = new EventEmitter();
|
|
|
|
assert.throws(
|
|
() => EE.emit('error', 'Accepts a string'),
|
|
{
|
|
code: 'ERR_UNHANDLED_ERROR',
|
|
name: 'Error',
|
|
message: "Unhandled error. ('Accepts a string')"
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => EE.emit('error', { message: 'Error!' }),
|
|
{
|
|
code: 'ERR_UNHANDLED_ERROR',
|
|
name: 'Error',
|
|
message: "Unhandled error. ({ message: 'Error!' })"
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => EE.emit('error', {
|
|
message: 'Error!',
|
|
[util.inspect.custom]() { throw new Error(); }
|
|
}),
|
|
{
|
|
code: 'ERR_UNHANDLED_ERROR',
|
|
name: 'Error',
|
|
message: 'Unhandled error. ([object Object])'
|
|
}
|
|
);
|