mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 20:29:36 +00:00
a74a6e3ba1
Throwing an exception from a finalizer can cause the following fatal
error:
Error: async hook stack has become corrupted (actual: 2, expected: 0)
1: 0x970b5a node::InternalCallbackScope::~InternalCallbackScope()
[./node]
2: 0x99dda0 node::Environment::RunTimers(uv_timer_s*) [./node]
3: 0x13d8b22 [./node]
4: 0x13dbe42 uv_run [./node]
5: 0xa57974 node::NodeMainInstance::Run() [./node]
6: 0x9dbc17 node::Start(int, char**) [./node]
7: 0x7f4965417f43 __libc_start_main [/lib64/libc.so.6]
8: 0x96f4ae _start [./node]
By https://github.com/nodejs/node/issues/34341#issuecomment-658426281,
calling into JS from a finalizer and/or throwing exceptions from there
is not advised, because the stack may or may not be set up for JS
execution. The best solution is to run the user's finalizer from a
`SetImmediate()` callback.
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Fixes: https://github.com/nodejs/node/issues/34341
PR-URL: https://github.com/nodejs/node/pull/34386
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
37 lines
1.3 KiB
JavaScript
37 lines
1.3 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-gc
|
|
|
|
const common = require('../../common');
|
|
const test_general = require(`./build/${common.buildType}/test_general`);
|
|
const assert = require('assert');
|
|
|
|
let finalized = {};
|
|
const callback = common.mustCall(2);
|
|
|
|
// Add two items to be finalized and ensure the callback is called for each.
|
|
test_general.addFinalizerOnly(finalized, callback);
|
|
test_general.addFinalizerOnly(finalized, callback);
|
|
|
|
// Ensure attached items cannot be retrieved.
|
|
assert.throws(() => test_general.unwrap(finalized),
|
|
{ name: 'Error', message: 'Invalid argument' });
|
|
|
|
// Ensure attached items cannot be removed.
|
|
assert.throws(() => test_general.removeWrap(finalized),
|
|
{ name: 'Error', message: 'Invalid argument' });
|
|
finalized = null;
|
|
global.gc();
|
|
|
|
// Add an item to an object that is already wrapped, and ensure that its
|
|
// finalizer as well as the wrap finalizer gets called.
|
|
async function testFinalizeAndWrap() {
|
|
assert.strictEqual(test_general.derefItemWasCalled(), false);
|
|
let finalizeAndWrap = {};
|
|
test_general.wrap(finalizeAndWrap);
|
|
test_general.addFinalizerOnly(finalizeAndWrap, common.mustCall());
|
|
finalizeAndWrap = null;
|
|
await common.gcUntil('test finalize and wrap',
|
|
() => test_general.derefItemWasCalled());
|
|
}
|
|
testFinalizeAndWrap();
|