mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 10:27:05 +00:00
caee112e52
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
59 lines
2.0 KiB
JavaScript
59 lines
2.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
// test uncompressing invalid input
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
const nonStringInputs = [
|
|
1,
|
|
true,
|
|
{ a: 1 },
|
|
['a']
|
|
];
|
|
|
|
// zlib.Unzip classes need to get valid data, or else they'll throw.
|
|
const unzips = [
|
|
zlib.Unzip(),
|
|
zlib.Gunzip(),
|
|
zlib.Inflate(),
|
|
zlib.InflateRaw()
|
|
];
|
|
|
|
nonStringInputs.forEach(common.mustCall((input) => {
|
|
// zlib.gunzip should not throw an error when called with bad input.
|
|
zlib.gunzip(input, function(err, buffer) {
|
|
// zlib.gunzip should pass the error to the callback.
|
|
assert.ok(err);
|
|
});
|
|
}, nonStringInputs.length));
|
|
|
|
unzips.forEach(common.mustCall((uz, i) => {
|
|
uz.on('error', common.mustCall());
|
|
uz.on('end', common.mustNotCall);
|
|
|
|
// this will trigger error event
|
|
uz.write('this is not valid compressed data.');
|
|
}, unzips.length));
|