mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 22:31:35 +00:00
caee112e52
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
84 lines
2.0 KiB
JavaScript
84 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
// Check that destroying the Http2ServerResponse stream produces
|
|
// the expected result, including the ability to throw an error
|
|
// which is emitted on server.streamError
|
|
|
|
const errors = [
|
|
'test-error',
|
|
Error('test')
|
|
];
|
|
let nextError;
|
|
|
|
const server = http2.createServer(common.mustCall((req, res) => {
|
|
req.on('error', common.mustNotCall());
|
|
res.on('error', common.mustNotCall());
|
|
|
|
res.on('finish', common.mustCall(() => {
|
|
res.destroy(nextError);
|
|
process.nextTick(() => {
|
|
res.destroy(nextError);
|
|
});
|
|
}));
|
|
|
|
if (req.url !== '/') {
|
|
nextError = errors.shift();
|
|
}
|
|
|
|
res.destroy(nextError);
|
|
}, 3));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const countdown = new Countdown(3, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
{
|
|
const req = client.request();
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.mustNotCall());
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.resume();
|
|
}
|
|
|
|
{
|
|
const req = client.request({ ':path': '/error' });
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 2'
|
|
}));
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
}
|
|
|
|
{
|
|
const req = client.request({ ':path': '/error' });
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 2'
|
|
}));
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
}
|
|
}));
|