mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 05:53:11 +00:00
caee112e52
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
34 lines
898 B
JavaScript
34 lines
898 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const fs = require('fs');
|
|
const callbackThrowValues = [null, true, false, 0, 1, 'foo', /foo/, [], {}];
|
|
|
|
const { sep } = require('path');
|
|
const warn = 'Calling an asynchronous function without callback is deprecated.';
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
function testMakeCallback(cb) {
|
|
return function() {
|
|
// fs.mkdtemp() calls makeCallback() on its third argument
|
|
fs.mkdtemp(`${tmpdir.path}${sep}`, {}, cb);
|
|
};
|
|
}
|
|
|
|
common.expectWarning('DeprecationWarning', warn);
|
|
|
|
// Passing undefined/nothing calls rethrow() internally, which emits a warning
|
|
testMakeCallback()();
|
|
|
|
function invalidCallbackThrowsTests() {
|
|
callbackThrowValues.forEach((value) => {
|
|
common.expectsError(testMakeCallback(value), {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
});
|
|
}
|
|
|
|
invalidCallbackThrowsTests();
|