mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 03:13:13 +00:00

There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
51 lines
1.2 KiB
JavaScript
51 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
fs.access(Buffer.from(tmpdir.path), common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
}));
|
|
|
|
const buf = Buffer.from(path.join(tmpdir.path, 'a.txt'));
|
|
fs.open(buf, 'w+', common.mustCall((err, fd) => {
|
|
assert.ifError(err);
|
|
assert(fd);
|
|
fs.close(fd, common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
}));
|
|
}));
|
|
|
|
common.expectsError(
|
|
() => {
|
|
fs.accessSync(true);
|
|
},
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "path" argument must be one of type string, Buffer, or URL'
|
|
}
|
|
);
|
|
|
|
const dir = Buffer.from(fixtures.fixturesDir);
|
|
fs.readdir(dir, 'hex', common.mustCall((err, hexList) => {
|
|
assert.ifError(err);
|
|
fs.readdir(dir, common.mustCall((err, stringList) => {
|
|
assert.ifError(err);
|
|
stringList.forEach((val, idx) => {
|
|
const fromHexList = Buffer.from(hexList[idx], 'hex').toString();
|
|
assert.strictEqual(
|
|
fromHexList,
|
|
val,
|
|
`expected ${val}, got ${fromHexList} by hex decoding ${hexList[idx]}`
|
|
);
|
|
});
|
|
}));
|
|
}));
|