mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 07:51:12 +00:00

There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
43 lines
856 B
JavaScript
43 lines
856 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const { Console } = require('console');
|
|
const { Writable } = require('stream');
|
|
|
|
for (const method of ['dir', 'log', 'warn']) {
|
|
{
|
|
const out = new Writable({
|
|
write: common.mustCall((chunk, enc, callback) => {
|
|
callback(new Error('foobar'));
|
|
})
|
|
});
|
|
|
|
const c = new Console(out, out, true);
|
|
|
|
c[method]('abc');
|
|
}
|
|
|
|
{
|
|
const out = new Writable({
|
|
write: common.mustCall((chunk, enc, callback) => {
|
|
throw new Error('foobar');
|
|
})
|
|
});
|
|
|
|
const c = new Console(out, out, true);
|
|
|
|
c[method]('abc');
|
|
}
|
|
|
|
{
|
|
const out = new Writable({
|
|
write: common.mustCall((chunk, enc, callback) => {
|
|
setImmediate(() => callback(new Error('foobar')));
|
|
})
|
|
});
|
|
|
|
const c = new Console(out, out, true);
|
|
|
|
c[method]('abc');
|
|
}
|
|
}
|