mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 22:16:16 +00:00
c981483686
Remove unnecessary variable assignments, remove unreachable code pathways, remove path getter and setter, and other very minor cleanup. Only remove reference to stream on nextTick so that users and libraries can access it in the finish event. Fixes: https://github.com/nodejs/node/issues/15313 Refs: https://github.com/expressjs/express/pull/3390 PR-URL: https://github.com/nodejs/node/pull/15254 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
// Flags: --expose-http2
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const net = require('net');
|
|
|
|
// Http2ServerRequest should expose convenience properties
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const expected = {
|
|
version: '2.0',
|
|
httpVersionMajor: 2,
|
|
httpVersionMinor: 0
|
|
};
|
|
|
|
assert.strictEqual(request.closed, false);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
|
|
assert.strictEqual(request.httpVersion, expected.version);
|
|
assert.strictEqual(request.httpVersionMajor, expected.httpVersionMajor);
|
|
assert.strictEqual(request.httpVersionMinor, expected.httpVersionMinor);
|
|
|
|
assert.ok(request.socket instanceof net.Socket);
|
|
assert.ok(request.connection instanceof net.Socket);
|
|
assert.strictEqual(request.socket, request.connection);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(request.closed, true);
|
|
assert.strictEqual(request.code, h2.constants.NGHTTP2_NO_ERROR);
|
|
server.close();
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|