mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 22:50:18 +00:00
c7bc9bcfbf
Removes branch that would make TLSSocket emit '_tlsError' event if error occured on handshake and control was not released, as it was never happening. Addedd test for tls.Server to ensure it still emits 'tlsClientError' as expected. Fixes: https://github.com/nodejs/node/issues/8803 PR-URL: https://github.com/nodejs/node/pull/8805 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
38 lines
932 B
JavaScript
38 lines
932 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
const tls = require('tls');
|
|
const net = require('net');
|
|
const assert = require('assert');
|
|
|
|
const bonkers = Buffer.alloc(1024, 42);
|
|
|
|
let tlsClientErrorEmited = false;
|
|
|
|
const server = tls.createServer({})
|
|
.listen(0, function() {
|
|
const c = net.connect({ port: this.address().port }, function() {
|
|
c.write(bonkers);
|
|
});
|
|
|
|
}).on('tlsClientError', function(e) {
|
|
tlsClientErrorEmited = true;
|
|
assert.ok(e instanceof Error,
|
|
'Instance of Error should be passed to error handler');
|
|
assert.ok(e.message.match(
|
|
/SSL routines:SSL23_GET_CLIENT_HELLO:unknown protocol/),
|
|
'Expecting SSL unknown protocol');
|
|
});
|
|
|
|
setTimeout(function() {
|
|
server.close();
|
|
|
|
assert.ok(tlsClientErrorEmited,
|
|
'tlsClientError should be emited');
|
|
|
|
}, common.platformTimeout(200));
|