mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 19:24:39 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
82 lines
2.1 KiB
JavaScript
82 lines
2.1 KiB
JavaScript
// Flags: --no-warnings
|
|
// The flag suppresses stderr output but the warning event will still emit
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const testMsg = 'A Warning';
|
|
const testCode = 'CODE001';
|
|
const testDetail = 'Some detail';
|
|
const testType = 'CustomWarning';
|
|
|
|
process.on('warning', common.mustCall((warning) => {
|
|
assert(warning);
|
|
assert(/^(?:Warning|CustomWarning)/.test(warning.name));
|
|
assert.strictEqual(warning.message, testMsg);
|
|
if (warning.code) assert.strictEqual(warning.code, testCode);
|
|
if (warning.detail) assert.strictEqual(warning.detail, testDetail);
|
|
}, 15));
|
|
|
|
class CustomWarning extends Error {
|
|
constructor() {
|
|
super();
|
|
this.name = testType;
|
|
this.message = testMsg;
|
|
this.code = testCode;
|
|
Error.captureStackTrace(this, CustomWarning);
|
|
}
|
|
}
|
|
|
|
[
|
|
[testMsg],
|
|
[testMsg, testType],
|
|
[testMsg, CustomWarning],
|
|
[testMsg, testType, CustomWarning],
|
|
[testMsg, testType, testCode],
|
|
[testMsg, { type: testType }],
|
|
[testMsg, { type: testType, code: testCode }],
|
|
[testMsg, { type: testType, code: testCode, detail: testDetail }],
|
|
[new CustomWarning()],
|
|
// Detail will be ignored for the following. No errors thrown
|
|
[testMsg, { type: testType, code: testCode, detail: true }],
|
|
[testMsg, { type: testType, code: testCode, detail: [] }],
|
|
[testMsg, { type: testType, code: testCode, detail: null }],
|
|
[testMsg, { type: testType, code: testCode, detail: 1 }]
|
|
].forEach((args) => {
|
|
process.emitWarning(...args);
|
|
});
|
|
|
|
const warningNoToString = new CustomWarning();
|
|
warningNoToString.toString = null;
|
|
process.emitWarning(warningNoToString);
|
|
|
|
const warningThrowToString = new CustomWarning();
|
|
warningThrowToString.toString = function() {
|
|
throw new Error('invalid toString');
|
|
};
|
|
process.emitWarning(warningThrowToString);
|
|
|
|
// TypeError is thrown on invalid input
|
|
[
|
|
[1],
|
|
[{}],
|
|
[true],
|
|
[[]],
|
|
['', '', {}],
|
|
['', 1],
|
|
['', '', 1],
|
|
['', true],
|
|
['', '', true],
|
|
['', []],
|
|
['', '', []],
|
|
[],
|
|
[undefined, 'foo', 'bar'],
|
|
[undefined]
|
|
].forEach((args) => {
|
|
assert.throws(
|
|
() => process.emitWarning(...args),
|
|
{ code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' }
|
|
);
|
|
});
|