mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 22:43:26 +00:00
eeccd52b4e
`net.Socket` is slightly breaking stream invariants by having readable/writable going from `false` to `true`. Streams assume that readable/writable starts out `true` and then goes to `false` through `push(null)`/`end()` after which it never goes back to `true`, e.g. once a stream is `writable == false` it is assumed it will never become `true`. This PR changes 2 things: Unless explicitly set to `false` through options: - starts as `readable`/`writable` `true` by default. - uses `push(null)`/`end()` to set `readable`/`writable` to `false`. Note that this would cause the socket to emit the `'end'`/`'finish'` events, which it did not do previously. In the case it is explicitly set to `false` through options` it is assumed to never become `true`. PR-URL: https://github.com/nodejs/node/pull/32272 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
66 lines
1.6 KiB
JavaScript
66 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cluster = require('cluster');
|
|
const net = require('net');
|
|
|
|
assert.throws(() => {
|
|
new net.Socket({ fd: -1 });
|
|
}, { code: 'ERR_OUT_OF_RANGE' });
|
|
|
|
assert.throws(() => {
|
|
new net.Socket({ fd: 'foo' });
|
|
}, { code: 'ERR_INVALID_ARG_TYPE' });
|
|
|
|
function test(sock, readable, writable) {
|
|
let socket;
|
|
if (sock instanceof net.Socket) {
|
|
socket = sock;
|
|
} else {
|
|
socket = new net.Socket(sock);
|
|
socket.unref();
|
|
}
|
|
|
|
assert.strictEqual(socket.readable, readable);
|
|
assert.strictEqual(socket.writable, writable);
|
|
}
|
|
|
|
if (cluster.isMaster) {
|
|
test(undefined, true, true);
|
|
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
socket.unref();
|
|
test(socket, true, true);
|
|
test({ handle: socket._handle }, true, true);
|
|
test({ handle: socket._handle, readable: true, writable: true },
|
|
true, true);
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(common.mustCall(() => {
|
|
const { port } = server.address();
|
|
const socket = net.connect(port, common.mustCall(() => {
|
|
test(socket, true, true);
|
|
socket.end();
|
|
}));
|
|
|
|
test(socket, true, true);
|
|
}));
|
|
|
|
cluster.setupMaster({
|
|
stdio: ['pipe', 'pipe', 'pipe', 'ipc', 'pipe', 'pipe', 'pipe']
|
|
});
|
|
|
|
const worker = cluster.fork();
|
|
worker.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
}));
|
|
} else {
|
|
test(4, true, true);
|
|
test({ fd: 5 }, true, true);
|
|
test({ fd: 6, readable: true, writable: true }, true, true);
|
|
process.disconnect();
|
|
}
|