mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 21:13:12 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
83 lines
2.0 KiB
JavaScript
83 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
// Check that destroying the Http2ServerResponse stream produces
|
|
// the expected result.
|
|
|
|
const errors = [
|
|
'test-error',
|
|
Error('test')
|
|
];
|
|
let nextError;
|
|
|
|
const server = http2.createServer(common.mustCall((req, res) => {
|
|
req.on('error', common.mustNotCall());
|
|
res.on('error', common.mustNotCall());
|
|
|
|
res.on('finish', common.mustCall(() => {
|
|
res.destroy(nextError);
|
|
process.nextTick(() => {
|
|
res.destroy(nextError);
|
|
});
|
|
}));
|
|
|
|
if (req.url !== '/') {
|
|
nextError = errors.shift();
|
|
}
|
|
|
|
res.destroy(nextError);
|
|
}, 3));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const countdown = new Countdown(3, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
{
|
|
const req = client.request();
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.mustNotCall());
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.resume();
|
|
}
|
|
|
|
{
|
|
const req = client.request({ ':path': '/error' });
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
name: 'Error',
|
|
message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'
|
|
}));
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
}
|
|
|
|
{
|
|
const req = client.request({ ':path': '/error' });
|
|
|
|
req.on('response', common.mustNotCall());
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
name: 'Error',
|
|
message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'
|
|
}));
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
}
|
|
}));
|