mirror of
https://github.com/nodejs/node.git
synced 2025-05-20 22:32:40 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
64 lines
1.7 KiB
JavaScript
64 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
const fs = require('fs');
|
|
const { promises } = fs;
|
|
const f = __filename;
|
|
|
|
// This test ensures that input for lchmod is valid, testing for valid
|
|
// inputs for path, mode and callback
|
|
|
|
if (!common.isOSX) {
|
|
common.skip('lchmod is only available on macOS');
|
|
}
|
|
|
|
// Check callback
|
|
assert.throws(() => fs.lchmod(f), { code: 'ERR_INVALID_CALLBACK' });
|
|
assert.throws(() => fs.lchmod(), { code: 'ERR_INVALID_CALLBACK' });
|
|
assert.throws(() => fs.lchmod(f, {}), { code: 'ERR_INVALID_CALLBACK' });
|
|
|
|
// Check path
|
|
[false, 1, {}, [], null, undefined].forEach((i) => {
|
|
assert.throws(
|
|
() => fs.lchmod(i, 0o777, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.lchmodSync(i),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|
|
|
|
// Check mode
|
|
[false, null, undefined, {}, [], '', '123x'].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError',
|
|
message: 'The argument \'mode\' must be a 32-bit unsigned integer or an ' +
|
|
`octal string. Received ${util.inspect(input)}`
|
|
};
|
|
|
|
assert.rejects(promises.lchmod(f, input, () => {}), errObj);
|
|
assert.throws(() => fs.lchmodSync(f, input), errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "mode" is out of range. It must be >= 0 && <= ' +
|
|
`4294967295. Received ${input}`
|
|
};
|
|
|
|
assert.rejects(promises.lchmod(f, input, () => {}), errObj);
|
|
assert.throws(() => fs.lchmodSync(f, input), errObj);
|
|
});
|