mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 10:27:12 +00:00

Export a new common.noop no-operation function for general use. Allow using common.mustCall() without a fn argument to simplify test cases. Replace various non-op functions throughout tests with common.noop PR-URL: https://github.com/nodejs/node/pull/12027 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
35 lines
676 B
JavaScript
35 lines
676 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
const expectedError = /^TypeError: "lookup" option should be a function$/;
|
|
|
|
['foobar', 1, {}, []].forEach((input) => connectThrows(input));
|
|
|
|
function connectThrows(input) {
|
|
const opts = {
|
|
host: 'localhost',
|
|
port: common.PORT,
|
|
lookup: input
|
|
};
|
|
|
|
assert.throws(function() {
|
|
net.connect(opts);
|
|
}, expectedError);
|
|
}
|
|
|
|
connectDoesNotThrow(common.noop);
|
|
|
|
function connectDoesNotThrow(input) {
|
|
const opts = {
|
|
host: 'localhost',
|
|
port: common.PORT,
|
|
lookup: input
|
|
};
|
|
|
|
assert.doesNotThrow(function() {
|
|
net.connect(opts);
|
|
});
|
|
}
|