mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 10:27:12 +00:00
45c4ad58e5
At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a process that is still starting up kills it with SIGKILL instead of SIGTERM. PR-URL: https://github.com/nodejs/node/pull/12159 Refs: https://github.com/libuv/libuv/issues/1226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
52 lines
1.7 KiB
JavaScript
52 lines
1.7 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
setTimeout(() => {
|
|
// The following console statements are part of the test.
|
|
console.log('child stdout');
|
|
console.error('child stderr');
|
|
}, common.platformTimeout(1000));
|
|
return;
|
|
}
|
|
|
|
const cmd = `${process.execPath} ${__filename} child`;
|
|
|
|
// Test the case where a timeout is set, and it expires.
|
|
cp.exec(cmd, { timeout: 1 }, common.mustCall((err, stdout, stderr) => {
|
|
assert.strictEqual(err.killed, true);
|
|
assert.strictEqual(err.code, null);
|
|
// At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a
|
|
// process that is still starting up kills it with SIGKILL instead of SIGTERM.
|
|
// See: https://github.com/libuv/libuv/issues/1226
|
|
if (common.isOSX)
|
|
assert.ok(err.signal === 'SIGTERM' || err.signal === 'SIGKILL');
|
|
else
|
|
assert.strictEqual(err.signal, 'SIGTERM');
|
|
assert.strictEqual(err.cmd, cmd);
|
|
assert.strictEqual(stdout.trim(), '');
|
|
assert.strictEqual(stderr.trim(), '');
|
|
}));
|
|
|
|
// Test with a different kill signal.
|
|
cp.exec(cmd, {
|
|
timeout: 1,
|
|
killSignal: 'SIGKILL'
|
|
}, common.mustCall((err, stdout, stderr) => {
|
|
assert.strictEqual(err.killed, true);
|
|
assert.strictEqual(err.code, null);
|
|
assert.strictEqual(err.signal, 'SIGKILL');
|
|
assert.strictEqual(err.cmd, cmd);
|
|
assert.strictEqual(stdout.trim(), '');
|
|
assert.strictEqual(stderr.trim(), '');
|
|
}));
|
|
|
|
// Test the case where a timeout is set, but not expired.
|
|
cp.exec(cmd, { timeout: 2 ** 30 }, common.mustCall((err, stdout, stderr) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(stdout.trim(), 'child stdout');
|
|
assert.strictEqual(stderr.trim(), 'child stderr');
|
|
}));
|