mirror of
https://github.com/nodejs/node.git
synced 2025-05-17 10:27:12 +00:00
a10e657657
This is a fix for test-child-process-exec-kill-throws which is currently flaky on Windows. A bug in the test was causing the child process to fail for reasons other than those intended by the test. Instead of failing for exceeding the `maxBuffer` setting, the test was failing because it was trying to load `internal/child_process` without being passed the `expose-internals` flag. Move that module to where only the parent process (which gets the flag) loads it. Additionally, improve an assertion message to help debug problems like this. PR-URL: https://github.com/nodejs/node/pull/12111 Fixes: https://github.com/nodejs/node/issues/12053 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
31 lines
1020 B
JavaScript
31 lines
1020 B
JavaScript
'use strict';
|
|
// Flags: --expose_internals
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
// Since maxBuffer is 0, this should trigger an error.
|
|
console.log('foo');
|
|
} else {
|
|
const internalCp = require('internal/child_process');
|
|
|
|
// Monkey patch ChildProcess#kill() to kill the process and then throw.
|
|
const kill = internalCp.ChildProcess.prototype.kill;
|
|
|
|
internalCp.ChildProcess.prototype.kill = function() {
|
|
kill.apply(this, arguments);
|
|
throw new Error('mock error');
|
|
};
|
|
|
|
const cmd = `${process.execPath} ${__filename} child`;
|
|
const options = { maxBuffer: 0 };
|
|
const child = cp.exec(cmd, options, common.mustCall((err, stdout, stderr) => {
|
|
// Verify that if ChildProcess#kill() throws, the error is reported.
|
|
assert.strictEqual(err.message, 'mock error', err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(stderr, '');
|
|
assert.strictEqual(child.killed, true);
|
|
}));
|
|
}
|