mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 09:08:46 +00:00
c1c226719f
`opts` in `createServer` will be immutable that won't change origional opts value. What's more, it's optional which can make `requestListener` be the first argument. PR-URL: https://github.com/nodejs/node/pull/13599 Fixes: https://github.com/nodejs/node/issues/13584 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const https = require('https');
|
|
const tls = require('tls');
|
|
|
|
const dftProtocol = {};
|
|
|
|
// test for immutable `opts`
|
|
{
|
|
const opts = { foo: 'bar', NPNProtocols: [ 'http/1.1' ] };
|
|
const server = https.createServer(opts);
|
|
|
|
tls.convertNPNProtocols([ 'http/1.1' ], dftProtocol);
|
|
assert.deepStrictEqual(opts, { foo: 'bar', NPNProtocols: [ 'http/1.1' ] });
|
|
assert.strictEqual(server.NPNProtocols.compare(dftProtocol.NPNProtocols), 0);
|
|
}
|
|
|
|
|
|
// validate that `createServer` can work with the only argument requestListener
|
|
{
|
|
const mustNotCall = common.mustNotCall();
|
|
const server = https.createServer(mustNotCall);
|
|
|
|
tls.convertNPNProtocols([ 'http/1.1', 'http/1.0' ], dftProtocol);
|
|
assert.strictEqual(server.NPNProtocols.compare(dftProtocol.NPNProtocols), 0);
|
|
assert.strictEqual(server.listeners('request').length, 1);
|
|
assert.strictEqual(server.listeners('request')[0], mustNotCall);
|
|
}
|
|
|
|
|
|
// validate that `createServer` can work with no arguments
|
|
{
|
|
const server = https.createServer();
|
|
|
|
assert.strictEqual(server.NPNProtocols.compare(dftProtocol.NPNProtocols), 0);
|
|
assert.strictEqual(server.listeners('request').length, 0);
|
|
}
|