mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 21:16:53 +00:00

I added it in commit57231d5286
("src: notify V8 profiler when we're idle") from October 2013 as a stop-gap measure to measure CPU time rather than wall clock time, otherwise processes that spend a lot of time sleeping in system calls give a false impression of being very busy. That fix is not without drawbacks because the idle flag is set before libuv makes I/O callbacks and cleared again after. I/O callbacks can result into calls into JS code and executing JS code is as non-idle as you can get. In commit96ffcb9a21
("src: reduce cpu profiler overhead") from January 2015, I made Node.js block off the SIGPROF signal that V8's CPU profiler uses before Node.js goes to sleep. The goal of that commit is to reduce the overhead from EINTR system call wakeups but it also has the pleasant side effect of fixing what the idle notifier tried to fix. This commit removes the idle notifier and turns the JS process object methods into no-ops. Fixes: https://github.com/nodejs/node/issues/19009 Refs: https://github.com/nodejs/node/pull/33138 PR-URL: https://github.com/nodejs/node/pull/34010 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
46 lines
1.1 KiB
JavaScript
46 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const { ObjectDefineProperty } = primordials;
|
|
|
|
delete process._debugProcess;
|
|
delete process._debugEnd;
|
|
|
|
function defineStream(name, getter) {
|
|
ObjectDefineProperty(process, name, {
|
|
configurable: true,
|
|
enumerable: true,
|
|
get: getter
|
|
});
|
|
}
|
|
|
|
defineStream('stdout', getStdout);
|
|
defineStream('stdin', getStdin);
|
|
defineStream('stderr', getStderr);
|
|
|
|
// Worker threads don't receive signals.
|
|
const {
|
|
startListeningIfSignal,
|
|
stopListeningIfSignal
|
|
} = require('internal/process/signal');
|
|
process.removeListener('newListener', startListeningIfSignal);
|
|
process.removeListener('removeListener', stopListeningIfSignal);
|
|
|
|
// ---- keep the attachment of the wrappers above so that it's easier to ----
|
|
// ---- compare the setups side-by-side -----
|
|
|
|
const {
|
|
createWorkerStdio
|
|
} = require('internal/worker/io');
|
|
|
|
let workerStdio;
|
|
function lazyWorkerStdio() {
|
|
if (!workerStdio) workerStdio = createWorkerStdio();
|
|
return workerStdio;
|
|
}
|
|
|
|
function getStdout() { return lazyWorkerStdio().stdout; }
|
|
|
|
function getStderr() { return lazyWorkerStdio().stderr; }
|
|
|
|
function getStdin() { return lazyWorkerStdio().stdin; }
|