mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 03:34:30 +00:00
c4fadbc15d
All the callback functions in `fs` module are supposed to be executed
with no context (`this` value should not be a valid object). But
`mkdtemp`'s callback will have the `FSReqWrap` object as the context.
Sample code to reproduce the problem
'use strict';
const fs = require('fs');
fs.mkdtemp('/tmp/abcd', null, function() {
console.log(this);
});
This would print
FSReqWrap { oncomplete: [Function] }
But that should have printed `null` and this patch fixes that.
PR-URL: https://github.com/nodejs/node/pull/7068
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
37 lines
1.2 KiB
JavaScript
37 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const Buffer = require('buffer').Buffer;
|
|
|
|
common.refreshTmpDir();
|
|
|
|
const tmpFolder = fs.mkdtempSync(path.join(common.tmpDir, 'foo.'));
|
|
|
|
assert(path.basename(tmpFolder).length === 'foo.XXXXXX'.length);
|
|
assert(common.fileExists(tmpFolder));
|
|
|
|
const utf8 = fs.mkdtempSync(path.join(common.tmpDir, '\u0222abc.'));
|
|
assert.equal(Buffer.byteLength(path.basename(utf8)),
|
|
Buffer.byteLength('\u0222abc.XXXXXX'));
|
|
assert(common.fileExists(utf8));
|
|
|
|
function handler(err, folder) {
|
|
assert.ifError(err);
|
|
assert(common.fileExists(folder));
|
|
assert.strictEqual(this, null);
|
|
}
|
|
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), common.mustCall(handler));
|
|
|
|
// Same test as above, but making sure that passing an options object doesn't
|
|
// affect the way the callback function is handled.
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), {}, common.mustCall(handler));
|
|
|
|
// Making sure that not passing a callback doesn't crash, as a default function
|
|
// is passed internally.
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-')));
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-'), {}));
|